Add File Classification for runtime pack #12578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonitra
force-pushed
the
fileclassification
branch
from
ba63ce9 to
e842bc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12578 +/- ##
===================================================
+ Coverage 75.82549% 75.83743% +0.01193%
===================================================
Files 3163 3164 +1
Lines 636410 636443 +33
Branches 47001 47002 +1
===================================================
+ Hits 482561 482662 +101
+ Misses 150378 150317 -61
+ Partials 3471 3464 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
cc @RussKie in case you are interested |
JeremyKuhne
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: dotnet/windowsdesktop#4796
This change includes file classification that is needed for the runtime pack in windowsdesktop in our FileClassification.props to avoid maintaining this list in the windowsdesktop repo. These dlls come from winforms so they should be maintained here and simply pulled into windowsdesktop like how we are already doing for the ref pack. The list is currently being maintained https://github.com/dotnet/windowsdesktop/blob/main/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Runtime.sfxproj#L22-L39
Microsoft Reviewers: Open in CodeFlow